[clfswm-devel] Some patches

[Philippe Brochard]

Michael Raitza writes:

> Hi,
>
Hi,

> I prepared a series of patches mostly improvements.
>
Thanks a lot. I've begin to apply some of them. I'll look others later.

> The first patch adds select-previous-child-simple, this function was
> missing somehow.
>
Commited

> The second patch modifies the frame-select-*-child functions to wrap
> around the end of the list of children. Isn't that the intended
> behaviour? I found it much more pleasing this way.
>
Commited. But this one break CLFSWM when there is no children in the
current frame (fixed).

> The third patch adds set-layout-simple. The other set-layout* functions
> were to be called from second mode if I understood correctly. I want to
> do it from main mode. Is there a general way to get rid of these second
> mode / main mode differences?
>
Commited but how do you use it?

> The fourth patch adds query-backspace-clear. To clear query input to the
> beginning of the line. (I have bound it to C-u like in vim and some
> shells.)
>
Commited. I've bound it to C-u and S-C-Backspace.

> In the fifth patch I have refactored run-program-from-query-string. This
> function could not be run from main mode because it binds the λ the
> function list to be run when leaving the second mode. So it was never
> called before entering and leaving second mode somewhen later. This
> patch introduces the function run-program-from-query-string-fun that
> does the actual query and generates the function.
> run-program-from-query-string uses its output. It also introduces
> run-program-from-query-string-main to be called from main mode.
>
I'll take a look at this one tomorrow.

> The third and fifth patch seem to be related, because they are causes by
> the differences of the functions called in second mode from functions
> providing the same functionality in main mode. Can't we consolidate
> these two concepts?
>
Same thing.


Many thanks for your patch!

While your are motivated to go deeply in the CLFSWM source code. There
is a thing CLFSWM will always lake if nobody other than me have a look
at it: CLFSWM communicate poorly with the outside: it is not fully netwm
compliant. You can have a look at src/netwm-util.lisp and at some
functions like netwm-update-desktop-property. 
I think there may be a time when users will want to use CLFSWM with
Gnome or KDE. netwm-util.lisp is here for this but this is really not a
priority for me. 

> Regards,
>
Regards,

Philippe