[slime-devel] [PATCH] slime profiling - little fix

[Pawel Ostrowski]

Hello,

When I was playing with slime profiling interface I encountered some
errors:

- CMUCL 18e complained about (profiled-functions, profile-report,
  profile-reset, unprofile-all, profile-package) symbols not being
  exported by swank package when I tried entries from slime/profiling
  menu. I just added missing exports to swank.lisp and it works fine,
  however I do not know slime code well so it may be not the best
  solution.
     I tried this with CLISP 2.32 and my fix helps too. Without the
  fix i get the following errors:

    error in process filter: cond: No frame at point
    error in process filter: No frame at point

- (slime-unprofile-all) had no effect on CMUCL 18e because it called
  (profile:unprofile) which is a macro. I replaced it with (eval
  '(profile:unprofile)) and now it works fine.

-- 
Pasza
pasza (at) zodiac.mimuw.edu.pl
-------------- next part --------------
Index: ChangeLog
===================================================================
RCS file: /project/slime/cvsroot/slime/ChangeLog,v
retrieving revision 1.290
diff -u -r1.290 ChangeLog
--- ChangeLog	10 Mar 2004 08:30:12 -0000	1.290
+++ ChangeLog	10 Mar 2004 11:13:11 -0000
@@ -1,3 +1,11 @@
+2004-03-10  Pawel Ostrowski  <pasza at zodiac.mimuw.edu.pl>
+
+	* swank-cmucl.lisp (unprofile-all): (eval '(profile:unprofile))
+	instead of just calling it since it is a macro in cmucl.
+
+	* swank.lisp (:swank): export profile symbols (profiled-functions,
+	profile-report, profile-reset, unprofile-all, profile-package)
+
 2004-03-10  Helmut Eller  <e9626484 at stud3.tuwien.ac.at>
 
 	* swank-allegro.lisp, swank-lispworks.lisp, swank-sbcl.lisp,
Index: swank.lisp
===================================================================
RCS file: /project/slime/cvsroot/slime/swank.lisp,v
retrieving revision 1.141
diff -u -r1.141 swank.lisp
--- swank.lisp	10 Mar 2004 08:23:19 -0000	1.141
+++ swank.lisp	10 Mar 2004 11:13:15 -0000
@@ -15,6 +15,11 @@
            #:ed-in-emacs
            
            #:frame-source-location-for-emacs
+           #:profiled-functions
+           #:profile-report
+           #:profile-reset
+           #:unprofile-all
+           #:profile-package
            ))
 
 (in-package :swank)
Index: swank-cmucl.lisp
===================================================================
RCS file: /project/slime/cvsroot/slime/swank-cmucl.lisp,v
retrieving revision 1.84
diff -u -r1.84 swank-cmucl.lisp
--- swank-cmucl.lisp	10 Mar 2004 09:10:33 -0000	1.84
+++ swank-cmucl.lisp	10 Mar 2004 11:13:20 -0000
@@ -1212,7 +1212,7 @@
   (eval `(profile:unprofile ,fname)))
 
 (defimplementation unprofile-all ()
-  (profile:unprofile)
+  (eval '(profile:unprofile))
   "All functions unprofiled.")
 
 (defimplementation profile-report ()