[imago-devel] convolve.lisp

[matthieu.villeneuve at free.fr]

Quoting Thibault Langlois <tl at di.fc.ul.pt>:
> > > another detail: SBCL complaints about a declaration in color.lisp:
> > >
> > > $ diff color.lisp color-orig.lisp
> > > 91,95c91
> > > <   (let ((colormap
> > > <          #-sbcl(make-array 256 :element-type '(unsigned-byte 8))
> > > <          ;; make-color does not return an (unsigned-byte 8) sbcl does
> > > <          ;; not like that.
> > > <          #+sbcl(make-array 256)))
> > > ---
> > > >   (let ((colormap (make-array 256 :element-type '(unsigned-byte 8))))
> >
> > Do you have any idea where exactly SBCL complains? It does not on my
> > machine, but I may not use the library the same way you do...
> >
> I get a warning:
>
> ; caught WARNING:
> ;   Asserted type (UNSIGNED-BYTE 8) conflicts with derived type
> ;   (VALUES (INTEGER 4278190080 4294967295) &OPTIONAL).
> ;   See also:
> ;     The SBCL Manual, Node "Handling of Types"
>
> This happens if I compile the MAKE-SIMPLE-GRAY-COLORMAP function.

Are you sure this version of the source code is up to date? I have

  (let ((colormap (make-array 256 :element-type 'rgb-pixel)))

instead...

> I noticed another missing gray-intensity in convert.lisp:

True, some other functions still considered gray pixels as 8-bit integers.
This should be fixed now.

Cheers,


--
Matthieu Villeneuve