From tc at xantira.com  Fri Jun  6 15:40:46 2008
From: tc at xantira.com (Matthias =?ISO-8859-1?Q?H=F6lzl?=)
Date: Fri, 06 Jun 2008 17:40:46 +0200
Subject: [flexi-streams-devel] SBCL Style-Warnings
Message-ID: <1212766846.10426.18.camel@localhost.localdomain>

When compiling flexi-streams 1.0.3, SBCL signals a number of style
warnings:

STYLE-WARNING: Implicitly creating new generic function READ-SEQUENCE*.
STYLE-WARNING: Implicitly creating new generic function CHECK-IF-OPEN.
STYLE-WARNING: Implicitly creating new generic function TRANSFORM-OCTET.
...

Would there be objections to introducing explicit definitions for these
generic functions?  

The attached patch introduces a new file "generics.lisp" that contains
defgenerics for the implicitly defined generics and includes that file
in the asdf definition for SBCL.  

In my opinion it would be nicer to put the defgenerics next to the
definitions of the methods.  I can provide a patch for that as well.

Best regards

  Matthias

-------------- next part --------------
A non-text attachment was scrubbed...
Name: flexi-streams-generics.patch
Type: text/x-patch
Size: 1390 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/flexi-streams-devel/attachments/20080606/1c780d75/attachment.bin>

From edi at agharta.de  Sat Jun  7 17:05:26 2008
From: edi at agharta.de (Edi Weitz)
Date: Sat, 07 Jun 2008 13:05:26 -0400
Subject: [flexi-streams-devel] SBCL Style-Warnings
In-Reply-To: <1212766846.10426.18.camel@localhost.localdomain> (Matthias
	=?iso-8859-1?q?H=F6lzl's?= message of "Fri, 06 Jun 2008 17:40:46 +0200")
References: <1212766846.10426.18.camel@localhost.localdomain>
Message-ID: <utzg5ch0p.fsf@agharta.de>

On Fri, 06 Jun 2008 17:40:46 +0200, Matthias H?lzl <tc at xantira.com> wrote:

> Would there be objections to introducing explicit definitions for
> these generic functions?

Yes... :)

Thanks anyway,
Edi.