From csr21 at cantab.net  Mon Jun  4 13:45:22 2007
From: csr21 at cantab.net (Christophe Rhodes)
Date: Mon, 04 Jun 2007 14:45:22 +0100
Subject: [climacs-devel] c-syntax and java syntax / list motion commands
Message-ID: <87ejkr25ql.fsf@cantab.net>

Hi,

I get a lot of forward-list method redefinition warnings from loading
climacs at the moment; is that intentional?  At a guess, it comes from
(drei-motion:define-motion-fns list) in c-syntax and java-syntax.

Cheers,

Christophe


From campbell at mumble.net  Mon Jun  4 14:34:20 2007
From: campbell at mumble.net (Taylor R Campbell)
Date: Mon, 4 Jun 2007 14:34:20 +0000
Subject: [climacs-devel] c-syntax and java syntax / list motion commands
In-Reply-To: <87ejkr25ql.fsf@cantab.net> (csr21@cantab.net)
Message-ID: <20070604143420.34345983AE@pluto.mumble.net>

   Date: Mon, 04 Jun 2007 14:45:22 +0100
   From: Christophe Rhodes <csr21 at cantab.net>

   I get a lot of forward-list method redefinition warnings from loading
   climacs at the moment; is that intentional?  At a guess, it comes from
   (drei-motion:define-motion-fns list) in c-syntax and java-syntax.

That code in c-syntax.lisp and java-syntax.lisp looks slightly
confused.  Drei already defines the motion functions for lists, in
mcclim/Drei/motion.lisp -- it both defines the basic FORWARD-ONE-* and
BACKWARD-ONE-* generics, and has DEFINE-MOTION-FNS for LIST.  I think
it would be safe to completely omit (DEFGENERIC FORWARD-ONE-LIST #),
(DEFGENERIC BACKWARD-ONE-LIST #), and (DREI-MOTION:DEFINE-MOTION-FNS
LIST), from c-syntax.lisp and java-syntax.lisp.


From campbell at mumble.net  Mon Jun  4 15:58:43 2007
From: campbell at mumble.net (Taylor R Campbell)
Date: Mon, 4 Jun 2007 15:58:43 +0000
Subject: [climacs-devel] c-syntax and java syntax / list motion commands
In-Reply-To: <87ejkr25ql.fsf@cantab.net> (csr21@cantab.net)
Message-ID: <20070604155843.95EF8983AE@pluto.mumble.net>

While loading Climacs myself, I also noticed a few other warnings that
shouldn't be there.  Loading text-syntax.lisp implicitly creates new
generic functions BACKWARD-ONE-PARAGRAPH, FORWARD-ONE-PARAGRAPH,
BACKWARD-ONE-SENTENC, and FORWARD-ONE-SENTENCE, all of which should
have been defined by DEFGENERIC in Drei.  The problem is that
text-syntax.lisp is loaded in the DREI-SYNTAX package, which doesn't
use DREI-MOTION, which is where those generics live.  I think that
text-syntax.lisp should probably be in its own package, as
packages.lisp suggests, which should use DREI-MOTION.