[cl-smtp-devel] reading server response - small fix

Ury Marshak ury.marshak at gmail.com
Sun Dec 26 17:48:14 UTC 2010


Hello,

I've found another small issue:
in READ-FROM-SMTP the last line  should read ...(append lines (list
response))
otherwise the lines are lost on multiline replies

Here's the diff for this fix together with the previous one (with encodings)

? .clbuild-skip-update
? ~cl-smtp.diff
Index: cl-smtp.lisp
===================================================================
RCS file: /project/cl-smtp/cvsroot/cl-smtp/cl-smtp.lisp,v
retrieving revision 1.20
diff -r1.20 cl-smtp.lisp
289,301c289,300
<            (setf stream
<                  #+allegro (socket:make-ssl-client-stream stream)
<                  #-allegro
<                  (let ((s (flexi-streams:flexi-stream-stream stream)))
<                    (cl+ssl:make-ssl-client-stream
<                     (cl+ssl:stream-fd s)
<                     :close-callback (lambda () (close s)))))
<            #-allegro
<            (setf stream (flexi-streams:make-flexi-stream
<                          stream
<                          :external-format
<                          (flexi-streams:make-external-format
<                           :latin-1 :eol-style :lf)))))
---
>            (let ((external-format
(flexi-streams:flexi-stream-external-format stream)))
>              (setf stream
>                    #+allegro (socket:make-ssl-client-stream stream)
>                    #-allegro
>                    (let ((s (flexi-streams:flexi-stream-stream stream)))
>                      (cl+ssl:make-ssl-client-stream
>                       (cl+ssl:stream-fd s)
>                       :close-callback (lambda () (close s)))))
>              #-allegro
>              (setf stream (flexi-streams:make-flexi-stream
>                            stream
>                            :external-format external-format)))))
490c489
<     (values response-code response lines))))
---
>     (values response-code response (append lines (list response))))))
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.common-lisp.net/pipermail/cl-smtp-devel/attachments/20101226/81758a84/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cl-smtp.diff
Type: application/octet-stream
Size: 1669 bytes
Desc: not available
URL: <https://mailman.common-lisp.net/pipermail/cl-smtp-devel/attachments/20101226/81758a84/attachment.obj>


More information about the cl-smtp-devel mailing list