From jan.idzikowski at knowledgetools.de Tue Apr 1 06:33:17 2008 From: jan.idzikowski at knowledgetools.de (Jan Idzikowski) Date: Tue, 01 Apr 2008 08:33:17 +0200 Subject: [cl-smtp-devel] Patch to support sending raw messages In-Reply-To: References: <1668532236.20080324005354@yandex.ru> <87ve3bew6m.wl@suse.knowledgetools.de> Message-ID: <87r6dqcceq.wl@suse.knowledgetools.de> Hi Hans, I'm back in berlin, you can send me the diff. Cheers, Jan From jan.idzikowski at knowledgetools.de Tue Apr 1 06:44:18 2008 From: jan.idzikowski at knowledgetools.de (Jan Idzikowski) Date: Tue, 01 Apr 2008 08:44:18 +0200 Subject: [cl-smtp-devel] Patch to support sending raw messages In-Reply-To: <1668532236.20080324005354@yandex.ru> References: <1668532236.20080324005354@yandex.ru> Message-ID: <87prtacbwd.wl@suse.knowledgetools.de> Hello Anton, I have investigated the CRLF transformation problem, '(:latin-1 :eol-style :lf) is wrong, this has to change to (make-external-format :latin-1) it use the *default-eol-style*. http://www.weitz.de/flexi-streams/#make-external-format Currently i have no access to a windows system to test it, but it should work. When I get the changes from Hans, I'll put this in the cvs repository. Cheers, Jan From avodonosov at yandex.ru Tue Apr 1 10:08:22 2008 From: avodonosov at yandex.ru (Anton Vodonosov) Date: Tue, 01 Apr 2008 14:08:22 +0400 Subject: [cl-smtp-devel] Patch to support sending raw messages In-Reply-To: 9110000000058118934 References: <1668532236.20080324005354@yandex.ru> 9110000000058118934 Message-ID: <843231207044502@webmail12.yandex.ru> 01.04.08, 10:44, "Jan Idzikowski" : > Hello Anton, > I have investigated the CRLF transformation problem, > '(:latin-1 :eol-style :lf) is wrong, this has to change to > (make-external-format :latin-1) it use the *default-eol-style*. > http://www.weitz.de/flexi-streams/#make-external-format > Currently i have no access to a windows system to test it, > but it should work. Using '(:latin-1 :eol-style :lf) is the point of the fix, because we want predictable conversion of #\Newline. With *default-eol-style* we would have (write-char #\Return sock) (write-char #\NewLine sock) resulting into CR CR LF on windows, instead of CR LF. Best regards, -Anton From ehuels at gmail.com Tue Apr 1 10:30:20 2008 From: ehuels at gmail.com (Erik Huelsmann) Date: Tue, 1 Apr 2008 12:30:20 +0200 Subject: [cl-smtp-devel] Patch to support sending raw messages In-Reply-To: <843231207044502@webmail12.yandex.ru> References: <1668532236.20080324005354@yandex.ru> <843231207044502@webmail12.yandex.ru> Message-ID: On Tue, Apr 1, 2008 at 12:08 PM, Anton Vodonosov wrote: > > > 01.04.08, 10:44, "Jan Idzikowski" : > > > > Hello Anton, > > I have investigated the CRLF transformation problem, > > '(:latin-1 :eol-style :lf) is wrong, this has to change to > > (make-external-format :latin-1) it use the *default-eol-style*. > > http://www.weitz.de/flexi-streams/#make-external-format > > Currently i have no access to a windows system to test it, > > but it should work. > > Using '(:latin-1 :eol-style :lf) is the point of the fix, > because we want predictable conversion of #\Newline. > > With *default-eol-style* we would have > > (write-char #\Return sock) > (write-char #\NewLine sock) > > resulting into CR CR LF on windows, instead of CR LF. I can confirm that we did something like that on Windows with CL-IRC (which also requires CRLF line endings in its protocol). Bye, Erik. From avodonosov at yandex.ru Tue Apr 1 12:27:57 2008 From: avodonosov at yandex.ru (Anton Vodonosov) Date: Tue, 01 Apr 2008 16:27:57 +0400 Subject: [cl-smtp-devel] Patch to support sending raw messages In-Reply-To: 9110000000058143082 References: <1668532236.20080324005354@yandex.ru> <87prtacbwd.wl@suse.knowledgetools.de> 9110000000058143082 Message-ID: <389261207052877@webmail53.yandex.ru> 01.04.08, 12:30, "Hans H?bner" : > Hi Jan, > find my current patch enclosed. ... > If there are other problems, please let me know. I would suggest to rename parameter :ssl to something else, for example :secure. The reason is that ssl and tls are almost synonyms; having (send-email ... :ssl :tls) in code is somewhat odd. There are also few peaces of code in the patch that may be simplified, but this is a minor issue and we may postpone it. Best regards, -Anton From hans at huebner.org Tue Apr 1 08:30:44 2008 From: hans at huebner.org (=?ISO-8859-1?Q?Hans_H=FCbner?=) Date: Tue, 1 Apr 2008 10:30:44 +0200 Subject: [cl-smtp-devel] Patch to support sending raw messages In-Reply-To: <87prtacbwd.wl@suse.knowledgetools.de> References: <1668532236.20080324005354@yandex.ru> <87prtacbwd.wl@suse.knowledgetools.de> Message-ID: Hi Jan, find my current patch enclosed. I have not put any time into seperating the SMTP protocol stuff from mail composition, but it should be easy to do. I know of one bug relating to AUTH handling in CL-SMTP::SMTP-AUTHENTICATE: Currently, if the server advertises more than AUTH protocol in one AUTH line, authentication will not work. This is easy to fix as well, but I can't spend any time on this until the weekend. Let me know if this is a real problem and I will plan on fixing this. If there are other problems, please let me know. Thanks, Hans 2008/4/1, Jan Idzikowski : > Hello Anton, > > I have investigated the CRLF transformation problem, > '(:latin-1 :eol-style :lf) is wrong, this has to change to > (make-external-format :latin-1) it use the *default-eol-style*. > http://www.weitz.de/flexi-streams/#make-external-format > > Currently i have no access to a windows system to test it, > but it should work. > When I get the changes from Hans, I'll put this in the cvs repository. > > Cheers, > > Jan > > -------------- next part -------------- A non-text attachment was scrubbed... Name: cl-smtp.diff Type: text/x-diff Size: 32001 bytes Desc: not available URL: From jan.idzikowski at knowledgetools.de Wed Apr 2 19:18:46 2008 From: jan.idzikowski at knowledgetools.de (Jan Idzikowski) Date: Wed, 02 Apr 2008 21:18:46 +0200 Subject: [cl-smtp-devel] Patch to support sending raw messages In-Reply-To: References: <1668532236.20080324005354@yandex.ru> <87prtacbwd.wl@suse.knowledgetools.de> Message-ID: <87od8sdq09.wl@suse.knowledgetools.de> Hi Hans, I applied your patch and fixed the bug in CL-SMTP::SMTP-AUTHENTICATE. While running my personal tests (on allegro/linux) i got a problem with your added #\Return after every #\Newline in smtp-output-stream.lisp line 78-79, I commented out these lines and it works for me. Now I tested it on linux with sbcl, cmucl, openmcl and allegro, but only with ssl support on sbcl. Further tests will follow. Cheers, Jan From hans at huebner.org Thu Apr 3 04:19:01 2008 From: hans at huebner.org (=?ISO-8859-1?Q?Hans_H=FCbner?=) Date: Thu, 3 Apr 2008 06:19:01 +0200 Subject: [cl-smtp-devel] Patch to support sending raw messages In-Reply-To: <87od8sdq09.wl@suse.knowledgetools.de> References: <1668532236.20080324005354@yandex.ru> <87prtacbwd.wl@suse.knowledgetools.de> <87od8sdq09.wl@suse.knowledgetools.de> Message-ID: 2008/4/2, Jan Idzikowski : > I applied your patch and fixed the bug in CL-SMTP::SMTP-AUTHENTICATE. Thanks! > While running my personal tests (on allegro/linux) i got a problem with > your added #\Return after every #\Newline > in smtp-output-stream.lisp line 78-79, I commented out these lines and > it works for me. I think this should be fixed for real - It may be that Allegros stream converts #\Newline to #\Return #\Newline - Sending an additional #\Return would then be wrong. If we can make sure that all streams do the conversion on all platforms, the #\Return addition can just go away. RFC2821 (2.3.7) mandates that outgoing lines are always terminated by #\Return #\Newline, so we'd better make sure that CL-SMTP does that, too. Thank you for the merge! Hans From avodonosov at yandex.ru Fri Apr 4 22:16:09 2008 From: avodonosov at yandex.ru (Anton Vodonosov) Date: Sat, 5 Apr 2008 01:16:09 +0300 Subject: [cl-smtp-devel] Patch to support sending raw messages In-Reply-To: References: <1668532236.20080324005354@yandex.ru> <87prtacbwd.wl@suse.knowledgetools.de> <87od8sdq09.wl@suse.knowledgetools.de> Message-ID: <1410035374.20080405011609@yandex.ru> Hi All. >> While running my personal tests (on allegro/linux) i got a problem with >> your added #\Return after every #\Newline >> in smtp-output-stream.lisp line 78-79, I commented out these lines and >> it works for me. > I think this should be fixed for real - It may be that Allegros stream > converts #\Newline to #\Return #\Newline - Sending an additional > #\Return would then be wrong. If we can make sure that all streams do > the conversion on all platforms, the #\Return addition can just go > away. > RFC2821 (2.3.7) mandates that outgoing lines are always terminated by > #\Return #\Newline, so we'd better make sure that CL-SMTP does that, > too. BTW, this is exactly the problem I suggested to fix with my patch, by opening socket as a binary stream and wrapping it into flexi-stream with explicitly specified #\Newline conversion. Best regards, -Anton From attila.lendvai at gmail.com Wed Apr 16 10:05:11 2008 From: attila.lendvai at gmail.com (Attila Lendvai) Date: Wed, 16 Apr 2008 12:05:11 +0200 Subject: [cl-smtp-devel] typo Message-ID: hi! this is probably a typo: Index: smtp-output-stream.lisp =================================================================== RCS file: /project/cl-smtp/cvsroot/cl-smtp/smtp-output-stream.lisp,v retrieving revision 1.1 diff -u -r1.1 smtp-output-stream.lisp --- smtp-output-stream.lisp 2 Apr 2008 18:02:29 -0000 1.1 +++ smtp-output-stream.lisp 16 Apr 2008 10:04:19 -0000 @@ -41,7 +41,7 @@ :reader external-format))) (defmethod stream-element-type ((stream smtp-output-stream)) - (stream-element-type (stream stream))) + (stream-element-type (encapsulated-stream stream))) (defmethod close ((stream smtp-output-stream) &key abort) (close (encapsulated-stream stream) :abort abort)) hth, -- attila From jan.idzikowski at knowledgetools.de Thu Apr 17 08:36:06 2008 From: jan.idzikowski at knowledgetools.de (Jan Idzikowski) Date: Thu, 17 Apr 2008 10:36:06 +0200 Subject: [cl-smtp-devel] typo In-Reply-To: References: Message-ID: <87myns2809.wl%jan.idzikowski@knowledgetools.de> Hello Attila, thanks for the bug report, i have fixed it. Cheers, Jan