From jrm at member.fsf.org Mon Oct 11 23:40:56 2010 From: jrm at member.fsf.org (J. Roberto B. de A. Monteiro) Date: Mon, 11 Oct 2010 20:40:56 -0300 Subject: [cl-gtk2-devel] Bug in gdk/gdk.gc.lisp Message-ID: <20101011234056.GA32376@igbt.sel.eesc.usp.br> Hello, I got a recent version cl-gtk2 by 'git clone' (I made a 'git pull' a few seconds ago). The slot name of gc-values is missing a char: it is written 'foregound' instead of 'foreground', in line 3 of gdk/gdk.gc.lisp: (foregound color :initform (make-color) :inline t) instead of: (foreground color :initform (make-color) :inline t) Regards, JRM From jordeam at gmail.com Tue Oct 12 02:25:35 2010 From: jordeam at gmail.com (=?UTF-8?B?Ikpvc8OpIFJvYmVydG8gQi4gZGUgQS4gTW9udGVpcm8i?=) Date: Mon, 11 Oct 2010 23:25:35 -0300 Subject: [cl-gtk2-devel] Some symbol names with problems Message-ID: <4CB3C71F.6010601@gmail.com> Hello, Maybe, some symbols regarding gdk:colormap and gdk:gc-values are with problems: 1. slot name in gc values are named as 'foregound' instead of 'foreground'. 2. gdk:colormap is defined as 'gdk:gdk-colormap' but spreadly used as 'gdk:colormap'. Folowing is a diff containing changes that makes the gdk package set different colors in drawing areas: ------------------------------------ diff --git a/gdk/gdk.gc.lisp b/gdk/gdk.gc.lisp index 9b274e2..2b1ddc6 100644 --- a/gdk/gdk.gc.lisp +++ b/gdk/gdk.gc.lisp @@ -1,7 +1,7 @@ (in-package :gdk) (define-g-boxed-cstruct gc-values nil - (foregound color :initform (make-color) :inline t) + (foreground color :initform (make-color) :inline t) (background color :initform (make-color) :inline t) (font (g-boxed-foreign font) :initform nil) (function gdk-function :initform :copy) diff --git a/gdk/gdk.objects.lisp b/gdk/gdk.objects.lisp index 3c540be..f2f9140 100644 --- a/gdk/gdk.objects.lisp +++ b/gdk/gdk.objects.lisp @@ -875,7 +875,7 @@ (:superclass g-object :export t :interfaces nil :type-initializer "gdk_image_get_type") - ((:cffi colormap gdk-image-colormap (g-object gdk-colormap) + ((:cffi colormap gdk-image-colormap (g-object colormap) "gdk_image_get_colormap" "gdk_image_set_colormap"))) (define-g-object-class "GdkDisplay" display (:type-initializer "gdk_display_get_type") @@ -930,7 +930,7 @@ (:cffi blue-shift visual-blue-shift :int gdk-visual-get-blue-shift nil) (:cffi blue-prec visual-blue-prec :int gdk-visual-get-blue-prec nil))) -(define-g-object-class "GdkColormap" gdk-colormap +(define-g-object-class "GdkColormap" colormap (:superclass g-object :export t :interfaces nil :type-initializer "gdk_colormap_get_type") ------------------------------------ Regards, JRM -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: diff URL: From kalyanov.dmitry at gmail.com Tue Oct 12 03:00:20 2010 From: kalyanov.dmitry at gmail.com (Kalyanov Dmitry) Date: Tue, 12 Oct 2010 07:00:20 +0400 Subject: [cl-gtk2-devel] Bug in gdk/gdk.gc.lisp In-Reply-To: <20101011234056.GA32376@igbt.sel.eesc.usp.br> References: <20101011234056.GA32376@igbt.sel.eesc.usp.br> Message-ID: <1286852420.3152.1.camel@dvk-laptop.localdomain> On Mon, 2010-10-11 at 20:40 -0300, J. Roberto B. de A. Monteiro wrote: > Hello, > > I got a recent version cl-gtk2 by 'git clone' (I made a 'git pull' a few seconds ago). > > The slot name of gc-values is missing a char: it is written 'foregound' instead of 'foreground', in line 3 of gdk/gdk.gc.lisp: > > (foregound color :initform (make-color) :inline t) > > instead of: > (foreground color :initform (make-color) :inline t) Thanks! I'll fix it. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part URL: From kalyanov.dmitry at gmail.com Tue Oct 12 03:01:02 2010 From: kalyanov.dmitry at gmail.com (Kalyanov Dmitry) Date: Tue, 12 Oct 2010 07:01:02 +0400 Subject: [cl-gtk2-devel] Some symbol names with problems In-Reply-To: <4CB3C71F.6010601@gmail.com> References: <4CB3C71F.6010601@gmail.com> Message-ID: <1286852462.3152.2.camel@dvk-laptop.localdomain> On Mon, 2010-10-11 at 23:25 -0300, "Jos? Roberto B. de A. Monteiro" wrote: > Hello, > > Maybe, some symbols regarding gdk:colormap and gdk:gc-values are with > problems: > > 1. slot name in gc values are named as 'foregound' instead of 'foreground'. > 2. gdk:colormap is defined as 'gdk:gdk-colormap' but spreadly used as > 'gdk:colormap'. Thank you! I'll commit the changes. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part URL: