[hunchentoot-devel] format string error in HANDLE-REQUEST

[Hans Hübner]

Desmond, Stas,

thank you for pointing at the bug and fixing it.  I've committed the
simplified format string.

-Hans

On Tue, Jun 8, 2010 at 07:23, Stas Boukarev <stassats at gmail.com> wrote:
> "Desmond O. Chang" <dochang at gmail.com> writes:
>
>> Hi all,
>>
>> In SBCL, HANDLE-REQUEST raises an error like this if
>> *LOG-LISP-BACKTRACE-P* is NIL:
>>
>>  error in FORMAT: no more arguments
>>    ~A~:[~*~;~%~:*~A~]
>>          ^
>>     [Condition of type SB-FORMAT:FORMAT-ERROR]
>>
>> Just remove the first ~* to fix it, or you can apply the attachment.
>>
>> Thanks,
>> Des.
>>
>> diff --git a/source/hunchentoot/acceptor.lisp b/source/hunchentoot/acceptor.lisp
>> index 44b7559..e5da7f1 100644
>> --- a/source/hunchentoot/acceptor.lisp
>> +++ b/source/hunchentoot/acceptor.lisp
>> @@ -439,7 +439,7 @@ handler."
>>                    (lambda (cond)
>>                      (when *log-lisp-errors-p*
>>                        (log-message *lisp-errors-log-level*
>> -                                   "~A~:[~*~;~%~:*~A~]"
>> +                                   "~A~:[~;~%~:*~A~]"
>>                                     cond
>>                                     (and *log-lisp-backtraces-p* (get-backtrace))))
>>                      ;; if the headers were already sent, the error
>
> Format string can be simplified to "~A~@[~%~A~]".
>
> --
> With Best Regards, Stas.
>
> _______________________________________________
> tbnl-devel site list
> tbnl-devel at common-lisp.net
> http://common-lisp.net/mailman/listinfo/tbnl-devel
>