[fiveam-devel] Github issues, IN-SUITE* semantics

[Olof-Joachim Frahm]

Hi all,

I've looked through the open issues on Github and would like to get some
input on a possible change/fix for issue #1, IN-SUITE* semantics:

A patch would be at [1], but I'm not sure this is the way to go.  The
change is to modify IN-SUITE*, so that it updates the existing suite if
possible.

That was not quite straight forward as I'd hoped, in particular, the use
of *SUITE* as the default value for :IN is a bit dangerous in this
situation, because without checking for that case, one can quite easily
create a loop from the updated suite to its parent, that is: itself, if
the form is evaluated multiple times.

So now I'm checking for that, but really, isn't T as the default parent
better?  Updating would be really easy that way.  Anyway, a testcase of
the expected(?) behaviour is included.  Of course deprecating IN-SUITE*
(in favour of DEF-SUITE*?) would fix this, but keeping defined tests
alive is a nice feature as well.  (Also, it doesn't seem to be used all
that often - on my system only elephant had some calls; admittedly
grepping all quicklisp packages to get more information would be nice.)


Other than that, issue #3, named lambdas is already fixed, right?  As far
as I can tell there's no way to force any more information into the
backtrace and NAMED-LAMBDA is already used, so the backtrace actually
contains enough hints about the involved test case.

Cheers,
Olof

[1]: https://github.com/Ferada/fiveam/commit/67eea929cb38b01a84a5285baf35e297e21b67cf