[cl-pdf-devel] patch to fix warnings
Gary King
gwking at metabang.com
Wed Jan 31 00:06:36 UTC 2007
Hi,
the patch below removes all of the compiler warnings (at least under
Allegro). Most of these are of the (declare (ignore ...)) variety
thought I also add a dependency between zlib and config in the system
definition and I change some "STRINGS" into :keywords to keep
Allegro's modern lisp happy.
¯If I don't hear a protest in the next day or so, I will commit it.
thanks,
Index: ttu-font.lisp
===================================================================
--- ttu-font.lisp (revision 130)
+++ ttu-font.lisp (working copy)
@@ -21,7 +21,6 @@
(length1 :accessor length1)))
(defmethod font-type ((fm ttu-font-metrics))
- (declare (ignore fm))
"Type0")
(defun load-ttu-font (ufm-file &optional ttf-file)
@@ -104,6 +103,7 @@
(defmethod make-dictionary ((fm ttu-font-metrics)
&key font (encoding (encoding font))
(embed *embed-fonts*))
+ (declare (ignore encoding))
(let* ((font-descriptor (font-descriptor fm :embed embed :errorp
nil))
(cid-font (make-instance
'cid-font
Index: chart.lisp
===================================================================
--- chart.lisp (revision 130)
+++ chart.lisp (working copy)
@@ -89,7 +89,7 @@
(height axis))
(defmethod draw-object (obj)
- )
+ (declare (ignore obj)))
(defun nice-number (n approx integer-p)
(let* ((n10 (expt 10 (floor (log n 10))))
@@ -303,14 +303,14 @@
for bx from gx by group-width do
(loop for y = 0.0 then (+ y dy)
for value in values
- for (name color) in (labels&colors obj)
+ for (nil color) in (labels&colors obj)
for dy = (* value scale) do
(apply #'set-rgb-fill color)
(basic-rect bx y bar-width dy)
(fill-and-stroke)))
(loop for serie in (series obj)
for gx from (* 0.5 spacing) by bar-width
- for (name color) in (labels&colors obj) do
+ for (nil color) in (labels&colors obj) do
(apply #'set-rgb-fill color)
(loop for value in serie
for dy = (* (- value min-value) scale)
@@ -351,7 +351,7 @@
(apply #'set-rgb-fill (background-color obj))
(fill-and-stroke)
(loop for angle in angles
- for (name color) in (labels&colors obj)
+ for (nil color) in (labels&colors obj)
for start = 0 then end
for end = (+ start angle) do
(apply #'set-rgb-fill color)
@@ -478,7 +478,7 @@
(set-line-width (line-width obj))
(set-line-join 2)
(loop for serie in (series obj)
- for (name color) in (labels&colors obj) do
+ for (nil color) in (labels&colors obj) do
(apply #'set-rgb-stroke color)
(apply #'set-rgb-fill color)
(let ((points '())
Index: font.lisp
===================================================================
--- font.lisp (revision 130)
+++ font.lisp (working copy)
@@ -85,6 +85,7 @@
;; TODO: Customize your lisp implementation in treating charset.
;; CAUTION: Don't use force-char-code from di-pdf.lisp!
(:method (char-or-code font encoding)
+ (declare (ignore encoding))
(aref (characters font) ;(force-char-code char-or-code)
(if (characterp char-or-code) (char-code char-or-code) char-
or-code))))
Index: font-metrics.lisp
===================================================================
--- font-metrics.lisp (revision 130)
+++ font-metrics.lisp (working copy)
@@ -293,7 +293,7 @@
(with-open-file (s filename :direction :input :external-format
+external-format+)
(setf font-metrics (afm-font-metrics s font-metrics-class)))
(setf void-char (gethash "VoidCharacter" (characters font-
metrics)))
- (iter (for (name char-metrics) in-hashtable (characters font-
metrics))
+ (iter (for (nil char-metrics) in-hashtable (characters font-
metrics))
(for gid = (index char-metrics))
(for code = (code char-metrics))
(when (and (<= 0 code #xfffe))
@@ -307,7 +307,7 @@
(vector-push-extend (vector (round (* 1000 (width char-
metrics)))) (cid-widths font-metrics))))
(setf encoding-vector (make-array (1+ max-code) :initial-
element void-char)
pdf-widths (make-array (1+ max-code) :initial-element 0))
- (iter (for (name char-metrics) in-hashtable (characters font-
metrics))
+ (iter (for (nil char-metrics) in-hashtable (characters font-
metrics))
(for code = (code char-metrics))
(when (<= min-code code max-code)
(setf (aref encoding-vector code) char-metrics
Index: pdf-base.lisp
===================================================================
--- pdf-base.lisp (revision 130)
+++ pdf-base.lisp (working copy)
@@ -109,15 +109,16 @@
(defmethod write-to-page :before ((string string) encoding &optional
escape)
- (declare (ignore escape))
+ (declare (ignore escape encoding))
(write-char #\( *page-stream*))
(defmethod write-to-page :after ((string string) encoding &optional
escape)
- (declare (ignore escape))
+ (declare (ignore escape encoding))
(write-string ") " *page-stream*))
(defmethod write-to-page ((string string) encoding &optional escape)
- (if escape
+ (declare (ignore encoding))
+ (if escape
(loop for char across string
do (case char
((#\( #\) #\\)
@@ -175,14 +176,15 @@
(defmethod write-to-page :before ((char character) encoding &optional
escape)
- (declare (ignore escape))
+ (declare (ignore escape encoding))
(write-char #\( *page-stream*))
(defmethod write-to-page :after ((char character) encoding &optional
escape)
- (declare (ignore escape))
+ (declare (ignore escape encoding))
(write-char #\) *page-stream*))
(defmethod write-to-page ((char character) encoding &optional escape)
+ (declare (ignore encoding))
(when escape (case char
((#\( #\) #\\) (write-char #\\ *page-stream*))))
(write-char char *page-stream*))
Index: iterate/package.lisp
===================================================================
--- iterate/package.lisp (revision 130)
+++ iterate/package.lisp (working copy)
@@ -31,6 +31,7 @@
with while until adjoining nconcing appending
nunioning unioning reducing accumulate accumulating))
-(export +clause-names+ '#:iterate)
+(eval-when (:compile-toplevel :load-toplevel :evaluate)
+ (export +clause-names+ '#:iterate))
;;; arch-tag: "b8bb0bb6-313c-11d8-abb9-000c76244c24"
Index: cl-pdf.asd
===================================================================
--- cl-pdf.asd (revision 130)
+++ cl-pdf.asd (working copy)
@@ -49,7 +49,9 @@
:components ((:file "defpackage")
(:file "config" :depends-on ("defpackage"))
#+use-uffi-zlib (:file "init" :depends-on ("config"))
- (:file "zlib" :depends-on ("defpackage" #+use-uffi-zlib
"init"))
+ (:file "zlib"
+ :depends-on ("config" "defpackage"
+ #+use-uffi-zlib "init"))
(:file "font-metrics" :depends-on ("config"))
(:file "encodings" :depends-on ("defpackage"))
(:file "t1-font" :depends-on ("font-metrics" "encodings"))
Index: x11-colors.lisp
===================================================================
--- x11-colors.lisp (revision 130)
+++ x11-colors.lisp (working copy)
@@ -769,7 +769,7 @@
(defvar *x11-color-keyword-map*
(let ((h (make-hash-table :test #'eq)))
(dolist (c *x11-colors*)
- (setf (gethash (intern (string-upcase (car c)) "KEYWORD")
+ (setf (gethash (intern (string-upcase (car c)) :keyword)
h)
(mapcar (lambda (v) (/ v 255.0))
(cdr c))))
--
Gary Warren King, metabang.com
Cell: (413) 885 9127
Fax: (206) 338-4052
gwkkwg on Skype * garethsan on AIM
More information about the cl-pdf-devel
mailing list