[cffi-devel] Re: wanted: testsuite .dll

James Bielman jamesjb at jamesjb.com
Mon Feb 13 04:38:51 UTC 2006


Jack Unrue <jdunrue at gmail.com> writes:

> You're right, thanks. Revised patch attached.

Sorry it took me a few days to look at this---I think this looks good,
but I'd suggest changing DEFCONSTANT to DEFPARAMETER since according
to a strict interpretation of the standard you can't redefine a
constant to a non-EQL value (SBCL will complain about this IIRC).

Also, I'd suggest putting the full year in the version string
"20060210" to make it a little more obvious what order the fields are
in.

Thanks,
James



More information about the cffi-devel mailing list